docs: Update contribution guidelines for issue creation and feature p…#176
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to a4e5002 in 58 seconds. Click for details.
- Reviewed
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/contributing.md:101
- Draft comment:
Good improvement – the instructions now clearly specify using issue templates for bug reports and feature proposals. Consider adding hyperlinks directly to the templates if available for even easier access. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. docs/contributing.md:117
- Draft comment:
The restructuring of the 'Proposing New Features' section into a numbered list improves clarity. This layout better differentiates initial discussions from formal proposals. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. docs/contributing.md:101
- Draft comment:
Clear improvement: instructing contributors to use specific templates for issue creation enhances clarity. Consider adding direct links to the 'Bug Report' and 'Detailed Feature Proposal' templates if available. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. docs/contributing.md:117
- Draft comment:
The revised 'Proposing New Features' section (numbered steps for initial discussion and formal proposal) improves clarity. Optionally, add a brief note clarifying the difference between these stages. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. docs/contributing.md:145
- Draft comment:
There's a potential typographical error on line 145: 'roo-cline-.vsix'. If this is intended to refer to 'Roo Code', it might need to be corrected to 'roo-code-.vsix' (or the appropriate file name). Please double-check if this is a mistake. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_Ro5RqMtlvCg1Fp5q
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed c39e341 in 56 seconds. Click for details.
- Reviewed
232lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. sidebars.ts:131
- Draft comment:
Changed the sidebar entry from a simple doc reference to an external link. Ensure that the link URL 'https://github.com/RooVetGit/Roo-Code/blob/main/CONTRIBUTING.md' is correct and that this change is consistent with the redesign (i.e., verifying that the CONTRIBUTING.md file exists and is maintained). Optionally, consider adding a 'target' attribute if you want the link to open in a new tab. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =30%<= threshold50%The comment is asking the PR author to ensure the correctness of a URL and its consistency with a redesign, which violates the rule against asking the author to confirm or ensure things. However, it also provides a suggestion about adding atargetattribute, which is a valid code suggestion. The comment is partially useful but mostly violates the rules.
2. docs/contributing.md:1
- Draft comment:
Ensure deletion of this file is intentional—confirm that contribution guidelines have been fully migrated to CONTRIBUTING.md and that all references are updated. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. sidebars.ts:133
- Draft comment:
Verify the new sidebar link correctly points to the updated CONTRIBUTING.md. The external link should match the intended documentation location. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_fpu1zxA8udobHbaG
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…roposals
Important
Remove
contributing.mdand update sidebar to link to GitHubCONTRIBUTING.md.contributing.mdfile, previously containing contribution guidelines.sidebars.tsto replace 'contributing' with a direct link to GitHubCONTRIBUTING.md.This description was created by
for c39e341. You can customize this summary. It will automatically update as commits are pushed.